Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate Content-Length header with same values #45

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

nleush
Copy link
Contributor

@nleush nleush commented Oct 4, 2017

Throw error only if values are different.

Known issues:
request/request#2091 (comment)
nodejs/node#6517 (comment)

Test url with duplicate headers:
https://bazimag.com/article/6989-the-evil-within-2-preview

nleush added a commit to itteco/iframely that referenced this pull request Oct 4, 2017
@Jimbly Jimbly merged commit 570c10c into creationix:master Oct 4, 2017
@Jimbly
Copy link
Collaborator

Jimbly commented Oct 4, 2017

Looks good, published to NPM as version 0.4.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants